diff --git a/announcement/tests.py b/announcement/tests.py index adab067f..a97b753c 100644 --- a/announcement/tests.py +++ b/announcement/tests.py @@ -30,8 +30,8 @@ class AnnouncementAdminTest(APITestCase): self.assertEqual(resp_data["content"], "test content") self.assertEqual(resp_data["visible"], False) - def test_delete_announcemen(self): + def test_delete_announcement(self): id = self.test_create_announcement().data["data"]["id"] - resp = self.client.delete(self.url, data={"id": id}) + resp = self.client.delete(self.url + "?id=" + str(id)) self.assertSuccess(resp) self.assertFalse(Announcement.objects.filter(id=id).exists()) diff --git a/announcement/views.py b/announcement/views.py index 04abf2cf..4d1d4496 100644 --- a/announcement/views.py +++ b/announcement/views.py @@ -1,7 +1,7 @@ from django.utils.translation import ugettext as _ from account.decorators import super_admin_required -from utils.api import APIView, IDOnlySerializer, validate_serializer +from utils.api import APIView, validate_serializer from .models import Announcement from .serializers import (AnnouncementSerializer, CreateAnnouncementSerializer, @@ -57,8 +57,8 @@ class AnnouncementAdminAPI(APIView): announcement = announcement.filter(visible=True) return self.success(self.paginate_data(request, announcement, AnnouncementSerializer)) - @validate_serializer(IDOnlySerializer) @super_admin_required def delete(self, request): - Announcement.objects.filter(id=request.data["id"]).delete() + if request.GET.get("id"): + Announcement.objects.filter(id=request.GET["id"]).delete() return self.success()