From 61cf177f15b9fa02322dbc230ad02c99b8b4794b Mon Sep 17 00:00:00 2001 From: ZanzyTHEbar Date: Sat, 13 Aug 2022 00:40:13 +0100 Subject: [PATCH] update - add some useful comments --- ESP/lib/src/network/webserver/webserverHandler.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ESP/lib/src/network/webserver/webserverHandler.cpp b/ESP/lib/src/network/webserver/webserverHandler.cpp index 0d0a8ec..25c6ddc 100644 --- a/ESP/lib/src/network/webserver/webserverHandler.cpp +++ b/ESP/lib/src/network/webserver/webserverHandler.cpp @@ -1,7 +1,6 @@ #include "webserverHandler.hpp" /* Constructor with unique_ptr */ - APIServer::APIServer(int CONTROL_PORT, CameraHandler *cameraHandler, WiFiHandler *network) : network(network), server(new AsyncWebServer(CONTROL_PORT)), cameraHandler(cameraHandler) {} @@ -13,7 +12,7 @@ void APIServer::startAPIServer() HTTP_GET, std::bind(&APIServer::command_handler, this, std::placeholders::_1)); */ - //! use lambdas instead of std::bind to avoid the overhead. + //! i have changed this to use lambdas instead of std::bind to avoid the overhead. Lambdas are always more preferable. this->server->on( "/control", HTTP_GET, [&](AsyncWebServerRequest *request) @@ -24,6 +23,7 @@ void APIServer::startAPIServer() this->server->begin(); } +//! To do - change this to use proper Hash Map to remove overhead of conditionals. void APIServer::command_handler(AsyncWebServerRequest *request) { if (request->hasParam("framesize"))