From 525ac10bbf2753230541c9b5d31672a50d243ba4 Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Sun, 8 Apr 2018 20:04:16 +0200 Subject: [PATCH] std::string -> const std::string& --- core/include/moveit/task_constructor/stages/connect.h | 2 +- core/include/moveit/task_constructor/stages/move_relative.h | 2 +- core/include/moveit/task_constructor/stages/move_to.h | 2 +- core/src/stages/connect.cpp | 2 +- core/src/stages/move_relative.cpp | 2 +- core/src/stages/move_to.cpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/include/moveit/task_constructor/stages/connect.h b/core/include/moveit/task_constructor/stages/connect.h index a37f057b..083afcfc 100644 --- a/core/include/moveit/task_constructor/stages/connect.h +++ b/core/include/moveit/task_constructor/stages/connect.h @@ -55,7 +55,7 @@ protected: public: typedef std::vector> GroupPlannerVector; - Connect(std::string name, const GroupPlannerVector& planners); + Connect(const std::string& name, const GroupPlannerVector& planners); void setTimeout(const ros::Duration& timeout){ setProperty("timeout", timeout.toSec()); diff --git a/core/include/moveit/task_constructor/stages/move_relative.h b/core/include/moveit/task_constructor/stages/move_relative.h index 82d403f9..22e34260 100644 --- a/core/include/moveit/task_constructor/stages/move_relative.h +++ b/core/include/moveit/task_constructor/stages/move_relative.h @@ -49,7 +49,7 @@ namespace moveit { namespace task_constructor { namespace stages { /** Perform a Cartesian motion relative to some link */ class MoveRelative : public PropagatingEitherWay { public: - MoveRelative(std::string name, const solvers::PlannerInterfacePtr& planner); + MoveRelative(const std::string& name, const solvers::PlannerInterfacePtr& planner); void init(const moveit::core::RobotModelConstPtr& robot_model) override; bool computeForward(const InterfaceState& from) override; diff --git a/core/include/moveit/task_constructor/stages/move_to.h b/core/include/moveit/task_constructor/stages/move_to.h index 1a44686d..cbd6e701 100644 --- a/core/include/moveit/task_constructor/stages/move_to.h +++ b/core/include/moveit/task_constructor/stages/move_to.h @@ -48,7 +48,7 @@ namespace moveit { namespace task_constructor { namespace stages { class MoveTo : public PropagatingEitherWay { public: - MoveTo(std::string name, const solvers::PlannerInterfacePtr& planner); + MoveTo(const std::string& name, const solvers::PlannerInterfacePtr& planner); void init(const moveit::core::RobotModelConstPtr& robot_model) override; bool computeForward(const InterfaceState& from) override; diff --git a/core/src/stages/connect.cpp b/core/src/stages/connect.cpp index 06d3332b..beeb19b6 100644 --- a/core/src/stages/connect.cpp +++ b/core/src/stages/connect.cpp @@ -42,7 +42,7 @@ namespace moveit { namespace task_constructor { namespace stages { -Connect::Connect(std::string name, const GroupPlannerVector& planners) +Connect::Connect(const std::string& name, const GroupPlannerVector& planners) : Connecting(name) , planner_(planners) { diff --git a/core/src/stages/move_relative.cpp b/core/src/stages/move_relative.cpp index 82cf4c74..5abc9f3a 100644 --- a/core/src/stages/move_relative.cpp +++ b/core/src/stages/move_relative.cpp @@ -43,7 +43,7 @@ namespace moveit { namespace task_constructor { namespace stages { -MoveRelative::MoveRelative(std::string name, const solvers::PlannerInterfacePtr& planner) +MoveRelative::MoveRelative(const std::string& name, const solvers::PlannerInterfacePtr& planner) : PropagatingEitherWay(name) , planner_(planner) { diff --git a/core/src/stages/move_to.cpp b/core/src/stages/move_to.cpp index f36a7fd3..2c6b66d3 100644 --- a/core/src/stages/move_to.cpp +++ b/core/src/stages/move_to.cpp @@ -43,7 +43,7 @@ namespace moveit { namespace task_constructor { namespace stages { -MoveTo::MoveTo(std::string name, const solvers::PlannerInterfacePtr& planner) +MoveTo::MoveTo(const std::string& name, const solvers::PlannerInterfacePtr& planner) : PropagatingEitherWay(name) , planner_(planner) {