diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 04dea516..ad765e57 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -14,22 +14,21 @@ jobs: fail-fast: false matrix: env: - # TODO: We have to use -Wno-redundant-decls since rosidl_generator_c is generating broken headers - IMAGE: humble-source CXXFLAGS: >- - -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-redundant-decls + -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-unused-parameter -Wno-unused-function -Wno-deprecated-copy -Wno-unused-but-set-parameter - IMAGE: rolling-source NAME: ccov TARGET_CMAKE_ARGS: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="--coverage" CXXFLAGS: >- - -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-redundant-decls + -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-unused-parameter -Wno-unused-function -Wno-deprecated-copy -Wno-unused-but-set-parameter - IMAGE: rolling-source CXX: clang++ CLANG_TIDY: true CXXFLAGS: >- - -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-redundant-decls + -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wno-unused-parameter -Wno-unused-function -Wno-deprecated-copy # Add fast_unwind_on_malloc=0 to fix stacktraces being too short or do not make sense # see https://github.com/google/sanitizers/wiki/AddressSanitizer diff --git a/.github/workflows/format.yaml b/.github/workflows/format.yaml index f6d56b2e..14e57570 100644 --- a/.github/workflows/format.yaml +++ b/.github/workflows/format.yaml @@ -13,11 +13,10 @@ jobs: name: pre-commit runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3 - name: Install clang-format-12 run: sudo apt-get install clang-format-12 - - uses: pre-commit/action@v2.0.0 + - uses: pre-commit/action@v3.0.0 id: precommit - name: Upload pre-commit changes if: failure() && steps.precommit.outcome == 'failure'