From f0a57850748edfc26a8ed90df107caf25b23ee31 Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Wed, 2 Nov 2022 17:20:52 +0100 Subject: [PATCH] Disable clang-tidy checks generating false positives --- .clang-tidy | 2 ++ visualization/motion_planning_tasks/test/test_task_model.cpp | 2 ++ .../motion_planning_tasks/utils/flat_merge_proxy_model.cpp | 1 + .../motion_planning_tasks/utils/tree_merge_proxy_model.cpp | 1 + 4 files changed, 6 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 9589fc7d..181fbf69 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,7 @@ --- Checks: 'performance-*, + -performance-noexcept-move-constructor, + -clang-analyzer-core.CallAndMessage, llvm-namespace-comment, modernize-redundant-void-arg, modernize-use-nullptr, diff --git a/visualization/motion_planning_tasks/test/test_task_model.cpp b/visualization/motion_planning_tasks/test/test_task_model.cpp index 8060235c..5d8f2f78 100644 --- a/visualization/motion_planning_tasks/test/test_task_model.cpp +++ b/visualization/motion_planning_tasks/test/test_task_model.cpp @@ -234,6 +234,8 @@ TEST_F(TaskListModelTest, deletion) { int main(int argc, char** argv) { ros::init(argc, argv, "test_task_model"); QCoreApplication app(argc, argv); + // https://bugs.llvm.org/show_bug.cgi?id=40367 + // NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks) QTimer::singleShot(0, [&]() { ::testing::InitGoogleTest(&argc, argv); auto testResult = RUN_ALL_TESTS(); diff --git a/visualization/motion_planning_tasks/utils/flat_merge_proxy_model.cpp b/visualization/motion_planning_tasks/utils/flat_merge_proxy_model.cpp index a8453d8a..343942a8 100644 --- a/visualization/motion_planning_tasks/utils/flat_merge_proxy_model.cpp +++ b/visualization/motion_planning_tasks/utils/flat_merge_proxy_model.cpp @@ -467,6 +467,7 @@ std::pair FlatMergeProxyModel::getModel(const const QModelIndex& src_index = d_ptr->mapToSource(index, data); Q_ASSERT(data); + // NOLINTNEXTLINE(clang-analyzer-core.NonNullParamChecker) return std::make_pair(data->model_, src_index); } diff --git a/visualization/motion_planning_tasks/utils/tree_merge_proxy_model.cpp b/visualization/motion_planning_tasks/utils/tree_merge_proxy_model.cpp index f57023ed..75e1ad30 100644 --- a/visualization/motion_planning_tasks/utils/tree_merge_proxy_model.cpp +++ b/visualization/motion_planning_tasks/utils/tree_merge_proxy_model.cpp @@ -440,6 +440,7 @@ std::pair TreeMergeProxyModel::getModel(const const QModelIndex& src_index = d_ptr->mapToSource(index, data); Q_ASSERT(data); + // NOLINTNEXTLINE(clang-analyzer-core.NonNullParamChecker) return std::make_pair(data->model_, src_index); }