- add some useful comments
This commit is contained in:
ZanzyTHEbar 2022-08-13 00:40:13 +01:00
parent e0ddf4697d
commit 61cf177f15

View File

@ -1,7 +1,6 @@
#include "webserverHandler.hpp" #include "webserverHandler.hpp"
/* Constructor with unique_ptr */ /* Constructor with unique_ptr */
APIServer::APIServer(int CONTROL_PORT, CameraHandler *cameraHandler, WiFiHandler *network) : network(network), APIServer::APIServer(int CONTROL_PORT, CameraHandler *cameraHandler, WiFiHandler *network) : network(network),
server(new AsyncWebServer(CONTROL_PORT)), server(new AsyncWebServer(CONTROL_PORT)),
cameraHandler(cameraHandler) {} cameraHandler(cameraHandler) {}
@ -13,7 +12,7 @@ void APIServer::startAPIServer()
HTTP_GET, HTTP_GET,
std::bind(&APIServer::command_handler, this, std::placeholders::_1)); */ std::bind(&APIServer::command_handler, this, std::placeholders::_1)); */
//! use lambdas instead of std::bind to avoid the overhead. //! i have changed this to use lambdas instead of std::bind to avoid the overhead. Lambdas are always more preferable.
this->server->on( this->server->on(
"/control", "/control",
HTTP_GET, [&](AsyncWebServerRequest *request) HTTP_GET, [&](AsyncWebServerRequest *request)
@ -24,6 +23,7 @@ void APIServer::startAPIServer()
this->server->begin(); this->server->begin();
} }
//! To do - change this to use proper Hash Map to remove overhead of conditionals.
void APIServer::command_handler(AsyncWebServerRequest *request) void APIServer::command_handler(AsyncWebServerRequest *request)
{ {
if (request->hasParam("framesize")) if (request->hasParam("framesize"))