Commit Graph

164 Commits

Author SHA1 Message Date
Robert Haschke
4aeab27ba3 Fix placement of Panel widget
Since #1611 and 41d62f5749b05c68131b752c605191518eaf19d5,
the floating argument for panels is correctly handled.
Here, we don't want the panel to be floating.
2021-06-11 09:52:17 +02:00
Robert Haschke
5dacc85ff9 Fix warning: control reaches end of non-void function 2021-06-10 07:35:09 +02:00
v4hn
f95fcf17b4 include OGRE headers via SYSTEM 2021-06-08 12:17:16 +02:00
Robert Haschke
437cc550f2 Add missing semicolons after cleanup of MoveIt 2021-05-29 00:38:43 +02:00
Robert Haschke
f070247a25 Fix compiler warnings 2021-05-27 22:24:29 +02:00
Robert Haschke
84ccd679d9 Fix compiler warnings
unused parameters and functions
2021-05-19 21:54:48 +02:00
Robert Haschke
94ff53e11e Fix catkin_lint warning
include paths 'motion_planning_tasks/src' and 'motion_planning_tasks' are ambiguous
2021-05-19 17:10:50 +02:00
Robert Haschke
cfcb1f274e Fix more clang-tidy issues 2021-04-24 02:12:24 +02:00
Robert Haschke
4fa8c10f44 clang-tidy auto-fixes 2021-04-24 02:03:24 +02:00
v4hn
fc5c25670d Fix duplicated layout name
Fixes https://github.com/ros-planning/moveit_task_constructor/issues/227
2021-03-22 14:38:30 +01:00
Robert Haschke
44eaf9975e rviz: catch + display invalid-robot-model exception 2021-03-19 18:22:04 +01:00
Robert Haschke
ef9c7612a9 Fix (again) creation of TaskPanel 2020-10-30 00:44:51 +01:00
Robert Haschke
f7ea72010b Fix ambiguous member initialization 2020-10-30 00:44:51 +01:00
Robert Haschke
e83a5ecefa Configurable handling of old remote tasks
- keep all previous tasks
- replace with next task of same id
- always remove
2020-10-30 00:44:51 +01:00
Robert Haschke
ae843a784e Merge PR #214 (fix various issues) and #215 (rework rviz introspection) 2020-10-24 04:45:53 +02:00
Robert Haschke
cf5031e89d Create task-specific ServiceClients to fetch solutions
This finally allows to have multiple tasks publishing in the same namespace.
2020-10-24 04:43:30 +02:00
Robert Haschke
c471879b08 Rename process_id -> task_id 2020-10-24 04:43:30 +02:00
Robert Haschke
b071a059f9 Rename TaskPrivate::id -> TaskPrivate::ns
TaskPrivate's id_ actually served as a namespace parameter.
2020-10-24 04:43:30 +02:00
Robert Haschke
c7151dcc48 Remove mainloop jobs
All topics are handled by the Display's update_nh_ within the main GUI thread anyway.
2020-10-24 03:23:19 +02:00
Robert Haschke
d78048719d Fix memory leakage 2020-10-24 03:23:19 +02:00
Robert Haschke
43828506b5 Fix TaskView segfault
We shouldn't "change" solution/property models if they didn't actually changed.
2020-10-24 03:23:19 +02:00
Robert Haschke
8b8666c64e TaskPanel: Fix assertion
When loading an .rviz config with MTC displays disabled, the mainloop_job to create a TaskPanel
will never be executed (because the display is disabled). Removing the display will then hit the
assertion that DISPLAY_COUNT > 0.
Fixed, by not relying on Display::update, but just scheduling a Qt GUI job via QTimer::singleShot().
2020-10-24 03:23:19 +02:00
Robert Haschke
d0dc384bdf Update TaskModel for all columns, including time 2020-09-22 10:56:11 +02:00
Michael Görner
ee6c50ad31
Apply clang-format-10 (#199) 2020-08-20 11:56:53 +02:00
Michael Görner
47f052b93d
adapt tests to new moveit_resources layout (#200) 2020-08-20 11:04:18 +02:00
v4hn
8cdd98943c document axiom in StageStatistics.solved
If the axiom is violated, sorting in the rviz panel will fail.
2020-08-11 20:43:34 +02:00
v4hn
8448a17b84 fixup: forward dataChanged signal for solutions too 2020-08-11 20:43:34 +02:00
v4hn
e8324abb78 remove trail visualization if task is deleted 2020-07-22 12:57:34 +02:00
v4hn
7ba73306ca introspection *can* be disabled
Otherwise a new task will always setup the publisher,
even if introspection is disabled afterwards.

It is a good idea to keep introspection on, but there should be a way to initialize the C++ classes without ROS communication.
2020-07-22 12:57:34 +02:00
v4hn
e8191bf14c only subscribe to statistics after receiving a non-reset description 2020-07-22 12:57:34 +02:00
v4hn
0aff5d56dd replace remaining typedefs by using declaration
I have no idea why these were not picked up by clang-tidy.
2020-07-22 12:57:34 +02:00
Michael Görner
4bee034768
Fixup: forward dataChanged() to QTreeView (#186) 2020-07-16 11:59:25 +02:00
v4hn
9dc43e49fe panel: start with all options expanded 2020-06-29 22:25:35 +02:00
v4hn
287287d23b panel: only local models can be edited 2020-06-29 22:25:35 +02:00
v4hn
da6d677991 add "show time column" to context menu 2020-06-29 22:25:35 +02:00
v4hn
6baf9f6a1b panel: optionally disable time column 2020-06-29 22:25:35 +02:00
v4hn
1b3f8fe8c3 panel: remove "interactive" add task from context menu
until there is anything reasonable to add. At the moment, there isn't.

This is one of the UI end-points for Robert's proposed drag&drop task system.
2020-06-29 22:25:35 +02:00
v4hn
95dad83126 panel: add margin above buttons 2020-06-29 22:25:35 +02:00
v4hn
7d510c79d3 solutions view: show the comment as tooltip
Makes much more sense than the internal id.
2020-06-29 22:25:35 +02:00
v4hn
853e7324e9 panel: have property-view occupy much less space by default
The initially more important part of the panel is clearly the task structure.
For longer tasks, the empty properties-view adds a scrollbar to the task when none would be needed.
2020-06-29 22:25:35 +02:00
v4hn
73fdca1708 panel: lower-case header texts
either all lower or all upper case.
2020-06-29 22:25:35 +02:00
v4hn
a380fea938 panel: unify alignment of header texts
User feedback said it's awkward and I quite agree. :)
2020-06-29 22:25:35 +02:00
v4hn
75bc6566f6 rework RViz panel
There's no need for individually resizable columns, but all numeric
content should autoresize and be visible all the time.

We will add an option to hide the time column in the future.

Remove intermediate AutoAdjustingTreeView layer to simplify code.
Resizing the columns did not work perfectly well before
and the auto_hide_cols_ feature was not really used.
2020-06-29 22:25:35 +02:00
v4hn
8faba159f9 clang-tidy: llvm-namespace-comment 2020-06-11 11:03:50 +02:00
v4hn
2153237643 clang-format: readability-identifier-naming
Probably the most invasive format patch, also changing some internal API.

I deliberately disabled ClassCase and MethodCase checks for the moment
to avoid public API changes in this patch set.
2020-06-11 11:03:50 +02:00
v4hn
b762079478 clang-tidy: readability-named-parameters 2020-06-11 11:03:50 +02:00
v4hn
5da2df4c61 clang-tidy: modernize-use-nullptr 2020-06-11 11:03:50 +02:00
v4hn
48f4c025ba clang-tidy: modernize-loop-convert 2020-06-11 11:03:50 +02:00
v4hn
3fe4436ad7 clang-tidy: modernize-use-override 2020-06-11 11:03:50 +02:00
v4hn
36166348bc clang-tidy: use using over typedef
$ run-clang-tidy.py -header-filter='.*' -checks='modernize-use-using' -fix

add .clang-tidy file
2020-06-11 11:03:50 +02:00