Commit Graph

1395 Commits

Author SHA1 Message Date
Sebastian Jahr
0c4b4fcaa8 Print warning if no controllers are configured for trajectory execution (#514) 2024-03-09 13:35:02 +01:00
Robert Haschke
739375298a Merge branch master into ros2 2024-03-09 13:34:36 +01:00
Robert Haschke
55c4b52b13 Cosmetic fixes 2024-03-09 11:11:01 +01:00
Robert Haschke
795bde7b62 Fix Solution::fillMessage() (#432)
The scene_diff field usually describes PlanningScene changes of the end scene relative to the start scene.
For backwards planning, this direction is reversed: the start scene is derived from the end scene.
Thus, we need to generate a full planning scene message for the end scene if planning progressed backwards.

Fixes #405.
2024-03-08 17:31:52 +01:00
Robert Haschke
2450127eb5 Clear JointStates in scene diff before execution
Joints are handled in trajectories.
Scene diffs should not modify joints during execution.
Fixes #353.

Alternative to #504. The previous solution, to always clear the joint states
during message generation, broke the visualization in rviz.
2024-03-08 17:16:19 +01:00
Robert Haschke
5a8925df11 Revert "Disable MPS tests, failing due to #432"
This reverts commit 5382338933.
2024-03-08 17:16:19 +01:00
Robert Haschke
4aac679257 Fix generation of Solution msg: consider backward operation
Need to generate full planning scene message if planning progressed backwards:
The scene_diff field describes PlanningScene changes of the end scene relative to the start scene,
while during planning it might be inversed.
2024-03-08 17:16:19 +01:00
Robert Haschke
5a42ca0ef8 CI: update action versions 2024-03-08 11:32:27 +01:00
Abishalini
e09fecd71f Propagate errors from planners to solution comment (#525) 2024-03-08 11:13:10 +01:00
Abishalini Sivaraman
5dd170b849 Add planner info to comments (#523) 2024-03-07 21:19:27 +01:00
TipluJacob
9b4c76076b Fix missing configs in demo launch files (#509) 2024-03-07 21:17:41 +01:00
Sebastian Jahr
f661c18e69 Fix MTC unittests for new pipeline refactoring (#515) 2024-03-07 20:53:45 +01:00
Mario Prats
11c3126052 Update to the more recent JumpThreshold API (#506) 2024-03-07 20:35:03 +01:00
Michael Wiznitzer
0827a0d260 JointInterpolationPlanner: Check joint bounds (#505) 2024-03-07 20:33:43 +01:00
Robert Haschke
d0a904c313 Add property trajectory_execution_info (#355, #502)
... to pass a list of controller names to PlanExecution

---------

Co-authored-by: Luca Lach <llach@techfak.uni-bielefeld.de>
2024-03-07 20:01:03 +01:00
JafarAbdi
c11a34a935 ExecuteTaskSolutionCapability: Reject new goals when busy (#496)
- Rename goalCallback() -> execCallback()
- Run execCallback asynchronously and use future to know status of execution
2024-03-07 16:01:15 +01:00
Robert Haschke
8695def99d ExecuteTaskSolutionCapability: Rename goalCallback() -> execCallback() 2024-03-07 14:36:43 +01:00
Robert Haschke
a75d50e0ed Clear JointStates in scene diff (#504)
Joints are handled in trajectories.
Scene diffs should not modify joints during execution.
Fixes #353.
2024-03-07 12:23:07 +01:00
Sebastian Jahr
b0f388a88f Set a non-infinite default timeout in CurrentState stage (#491)
Co-authored-by: Mario Prats <mario.prats@picknik.ai>
2024-03-07 12:23:07 +01:00
Robert Haschke
48ca3d46f6 rviz_marker_tools: drop rviz dependency 2024-03-07 12:23:07 +01:00
Henning Kayser
111d9ba207
Add GenerateRandomPose stage (#166)
Implements a generic pose randomizer

Co-authored-by: JafarAbdi <cafer.abdi@gmail.com>
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
2024-03-06 22:32:13 +01:00
Sebastian Jahr
1e058598c7 Add planner_id to SubTrajectory info (#490) 2024-03-06 18:11:57 +01:00
Sebastian Jahr
ed70497d33 Remove display_motion_plans and publish_planning_requests properties (#489) 2024-03-06 15:59:39 +01:00
Sebastian Jahr
0e02fcae77 Enable parallel planning with PipelinePlanner (#450)
* Refactor pipeline planner

Make code readable

Re-order plan functions

Make usable with parallel planning

Enable configuring multiple pipelines

Add callbacks

Cleanup and documentation

Add API to set parallel planning callbacks and deprecate functions

Pass pipeline map by reference

Small clang-tidy fix

Update core/src/solvers/pipeline_planner.cpp

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>

Update core/src/solvers/pipeline_planner.cpp

Format

Refactor to avoid calling .at(0) twice

Use no default stopping criteria

Update fallbacks_move demo

* Cleanup + address deprecation warnings

* Enabling optionally using a property defined pipeline planner map

* Address review

* Disable humble CI for ros2 branch

* Add pipeline planner unittests + some checks

* Add short comment
2024-03-06 15:59:09 +01:00
Captain Yoshi
911bc67c4d
GenerateGraspPose: Expose rotation_axis as property (#535) 2024-03-06 11:02:44 +01:00
Captain Yoshi
5720b83dce
Connect: ensure end-state matches goal state (#532) 2024-02-25 16:58:56 +01:00
Michael Görner
7638e5ff8b
Merge pull request #495 from ubi-agni/debug-#485
[WIP] Debug/Fix #485
2024-02-16 12:27:36 +01:00
Robert Haschke
275c15422d Adaptions for https://github.com/ros-planning/moveit/pull/3534
make_box() is a public method now
2024-02-15 22:20:34 +01:00
Robert Haschke
e163f57f9c Cleanup debug output 2024-02-15 21:42:18 +01:00
Robert Haschke
9dfd6bd2eb Fix duplicate solutions
When adding pending state pairs for a new incoming state to Connect,
we have to re-enable opposite states from ARMED state.
This changes the order of states in the interface.
If we do this while iterating over the states, we might add pairs multiple times,
because iteration continues with same state at an earlier position.
2024-02-15 21:42:18 +01:00
Robert Haschke
bf2714b42d printPendingPairs(os) -> os<<pendingPairsPrinter() 2023-10-25 22:21:36 +02:00
Robert Haschke
13264ba21d Fix leaking of failures into enumerated solutions 2023-10-25 22:21:36 +02:00
Robert Haschke
7b965863e3 Add more debugging output
- Add Stage::introspection() accessor
- Introspection: debug-log solution registration
- RemoteSolutionModel: show internal solution id as tooltip in 1st column
2023-10-25 22:19:49 +02:00
Robert Haschke
08b102d5b0 Unit tests for #485 2023-10-20 09:23:32 +02:00
Robert Haschke
605a1e5419 DelayingWrapper stage to delay solution shipping in unit tests 2023-10-20 09:23:32 +02:00
Robert Haschke
0fd989cb27 Simplify tests 2023-10-13 00:25:39 +02:00
Michael Görner
a90557279c
Hide button to show rviz-based task construction (#492) 2023-10-11 14:52:28 +02:00
Michael Görner
dcde89d4d5
Skip Fallbacks::replaceImpl() when already correctly initialized (#494)
Do not reinitialize a Fallbacks' pimpl if it already serves the desired interface.
2023-10-11 14:45:24 +02:00
Michael Görner
ab4bb40dfd
Fix demos (#493)
* improve demo rviz config
  - orbit view centered at workspace instead of 2d orbit
  - REALTIME trajectory display
* FixedState: setter for ignore_collisions property
* Fix clearance_cost demo
  - verify default state
  - use model frame over virtual "world" which is not known in fresh PlanningScene
  - ignore initial collisions with the IK seed
* improve documentation in Fallbacks demo
2023-10-11 14:30:54 +02:00
Henning Kayser
64fd3df563
README: Add branch description (#488) 2023-10-03 17:28:27 +02:00
Robert Haschke
f847d765ce Fix Qt 5.15 deprecation warnings 2023-09-18 10:51:25 +02:00
Robert Haschke
647f3ec413 Limit time to wait for execute_task_solution action server 2023-09-18 10:35:23 +02:00
Robert Haschke
0ba9796fe8 Revert "Silent googletest warnings"
This reverts commit 16af904e05.
The corresponding upstream fixes were merged into ament packages.
2023-07-26 08:21:10 +02:00
Robert Haschke
349e3c6c6c Merge branch master into ros2 2023-05-26 16:38:15 +02:00
Robert Haschke
c605a0059a Replace namespace robot_[model|state] with moveit::core 2023-05-26 01:18:17 +02:00
Robert Haschke
6f7282423d MPS: fixup processCollisionObject
- Declare CollisionObject argument as constant:
  Internally the argument is temporarily modified, but for a caller it is effectively const.
- Correctly restore the old operation mode
- Fixup check in unit test
2023-05-26 01:15:50 +02:00
Robert Haschke
3ec69fb59d
Merge PR #460: improvements to ModifyPlanningScene stage 2023-05-25 22:29:31 +02:00
Robert Haschke
2728b3c94c Remove downstream package mtc_pour
... as fillMessage() was renamed to toMsg()
2023-05-25 22:07:35 +02:00
Robert Haschke
5382338933 Disable MPS tests, failing due to #432 2023-05-25 21:52:07 +02:00
Robert Haschke
78da3e46e6
Gracefully handle NULL robot_trajectory (#469) 2023-05-25 17:49:23 +02:00