v4hn
8cdd98943c
document axiom in StageStatistics.solved
...
If the axiom is violated, sorting in the rviz panel will fail.
2020-08-11 20:43:34 +02:00
v4hn
e861d311e0
fix comment typo
2020-08-11 20:43:34 +02:00
v4hn
8448a17b84
fixup: forward dataChanged signal for solutions too
2020-08-11 20:43:34 +02:00
Michael Görner
85940b4f3d
README: add tutorial reference
2020-08-10 10:27:03 +02:00
v4hn
d031f1b1e3
send a single reset message when introspection is enabled
...
My previous patches accidentally disabled *all* (3) reset messages,
instead of keeping exactly one. This patch sends exactly one empty description
(reset) message every time an introspection instance is constructed for a task.
Notice the additional increase of the description queue_size from 1 to 2 to avoid
directly dropping the reset message in favor of the new description likely to be send
shortly afterwards.
2020-07-22 12:57:34 +02:00
v4hn
e8324abb78
remove trail visualization if task is deleted
2020-07-22 12:57:34 +02:00
v4hn
7ba73306ca
introspection *can* be disabled
...
Otherwise a new task will always setup the publisher,
even if introspection is disabled afterwards.
It is a good idea to keep introspection on, but there should be a way to initialize the C++ classes without ROS communication.
2020-07-22 12:57:34 +02:00
v4hn
e8191bf14c
only subscribe to statistics after receiving a non-reset description
2020-07-22 12:57:34 +02:00
v4hn
0aff5d56dd
replace remaining typedefs by using declaration
...
I have no idea why these were not picked up by clang-tidy.
2020-07-22 12:57:34 +02:00
v4hn
21f3d95128
fix autocomplete typo
2020-07-22 12:57:34 +02:00
Michael Görner
4bee034768
Fixup: forward dataChanged() to QTreeView ( #186 )
2020-07-16 11:59:25 +02:00
Michael Görner
8cb57d65d4
README.md: fix formatting
...
Quotation environment does not allow link syntax
2020-07-09 17:34:46 +02:00
Robert Haschke
0902d432ce
Improve code readability
2020-07-01 22:13:21 +02:00
Michael Görner
a86bb4248a
Merge pull request #146 from v4hn/pr-master-rework-panel
...
rework RViz panel
2020-06-30 11:40:39 +02:00
v4hn
9dc43e49fe
panel: start with all options expanded
2020-06-29 22:25:35 +02:00
v4hn
287287d23b
panel: only local models can be edited
2020-06-29 22:25:35 +02:00
v4hn
da6d677991
add "show time column" to context menu
2020-06-29 22:25:35 +02:00
v4hn
6baf9f6a1b
panel: optionally disable time column
2020-06-29 22:25:35 +02:00
v4hn
1b3f8fe8c3
panel: remove "interactive" add task from context menu
...
until there is anything reasonable to add. At the moment, there isn't.
This is one of the UI end-points for Robert's proposed drag&drop task system.
2020-06-29 22:25:35 +02:00
v4hn
95dad83126
panel: add margin above buttons
2020-06-29 22:25:35 +02:00
v4hn
7d510c79d3
solutions view: show the comment as tooltip
...
Makes much more sense than the internal id.
2020-06-29 22:25:35 +02:00
v4hn
853e7324e9
panel: have property-view occupy much less space by default
...
The initially more important part of the panel is clearly the task structure.
For longer tasks, the empty properties-view adds a scrollbar to the task when none would be needed.
2020-06-29 22:25:35 +02:00
v4hn
73fdca1708
panel: lower-case header texts
...
either all lower or all upper case.
2020-06-29 22:25:35 +02:00
v4hn
a380fea938
panel: unify alignment of header texts
...
User feedback said it's awkward and I quite agree. :)
2020-06-29 22:25:35 +02:00
v4hn
75bc6566f6
rework RViz panel
...
There's no need for individually resizable columns, but all numeric
content should autoresize and be visible all the time.
We will add an option to hide the time column in the future.
Remove intermediate AutoAdjustingTreeView layer to simplify code.
Resizing the columns did not work perfectly well before
and the auto_hide_cols_ feature was not really used.
2020-06-29 22:25:35 +02:00
YannickRiou
25fea7198a
Avoid error about moc_xxx files not found ( #181 )
...
Avoid error about moc_xxx files not found.
* Added include dir option in CMakeList to avoid error on moc_xxx files generation
2020-06-29 22:22:21 +02:00
v4hn
11132c8e59
codecov: informational only
...
For some reason CodeCov testing fails at the moment.
This shouldn't block requests for this project at the moment.
2020-06-19 22:28:51 +02:00
Robert Haschke
ee7ebb3b96
SolutionMsg: always fill start_scene ( #175 )
...
So far, the start_scene field of a SolutionMsg was only filled by Introspection::fillSolution(),
but not yet by Task::execute().
Addendum(v4hn): The previous approach was actually reasonable too (although the scene should have been marked as `is_diff`) for solutions sent for execution, but keeping the full start_scene around can facilitate debugging from recorded data.
2020-06-18 11:07:05 +02:00
v4hn
4fa706660e
improve README
2020-06-14 22:40:28 +02:00
Robert Haschke
1610f5ab1d
MoveRelative: provide failure message
2020-06-13 22:48:48 +02:00
v4hn
f262d3058f
add other checks present in the main MoveIt repository
...
These did not entail any changes in our current codebase.
2020-06-11 11:03:50 +02:00
v4hn
15707673ed
clang-tidy: performance-*
...
I NOLINTed the noexcept move constructor for Task for now because
the constructor *can* indeed throw exceptions.
2020-06-11 11:03:50 +02:00
v4hn
8faba159f9
clang-tidy: llvm-namespace-comment
2020-06-11 11:03:50 +02:00
v4hn
2153237643
clang-format: readability-identifier-naming
...
Probably the most invasive format patch, also changing some internal API.
I deliberately disabled ClassCase and MethodCase checks for the moment
to avoid public API changes in this patch set.
2020-06-11 11:03:50 +02:00
v4hn
fa041ed2e6
clang-format: readability-container-size-empty
2020-06-11 11:03:50 +02:00
v4hn
b762079478
clang-tidy: readability-named-parameters
2020-06-11 11:03:50 +02:00
v4hn
5da2df4c61
clang-tidy: modernize-use-nullptr
2020-06-11 11:03:50 +02:00
v4hn
48f4c025ba
clang-tidy: modernize-loop-convert
2020-06-11 11:03:50 +02:00
v4hn
3fe4436ad7
clang-tidy: modernize-use-override
2020-06-11 11:03:50 +02:00
v4hn
36166348bc
clang-tidy: use using over typedef
...
$ run-clang-tidy.py -header-filter='.*' -checks='modernize-use-using' -fix
add .clang-tidy file
2020-06-11 11:03:50 +02:00
v4hn
c662311a78
grant access to subsolutions of a sequence
...
SubTrajectory allows to access the trajectory,
but for SolutionSequence is was not needed until now.
2020-06-11 11:03:50 +02:00
v4hn
98cac4fd7c
add informative comment
2020-06-11 11:03:50 +02:00
v4hn
9f07cf5e97
shorten task id if Task object has no name
2020-06-11 11:03:50 +02:00
v4hn
ebf7b751d2
do not reset on plan
...
users can reset explicitly as needed.
Reset sends ROS messages and prevents { plan(1); plan(1) } style usage.
2020-06-11 11:03:50 +02:00
v4hn
7270a658af
connect to statistics *after* first description
...
This avoids the case where we would asynchronously receive the statistics
*before* the description and wouldn't know what to do with it.
2020-06-11 11:03:50 +02:00
v4hn
701589b651
simplify reading
...
my eyes hurt trying to cope with it.first->second .
2020-06-11 11:03:50 +02:00
v4hn
b9839a3f22
check for valid robot model
...
Also, no need to reset() unless the model is different and not the first.
2020-06-11 11:03:50 +02:00
v4hn
b27939cb27
fix typo
2020-06-11 11:03:50 +02:00
v4hn
d224097f3f
extend comment on unintuitive setter
2020-06-11 11:03:50 +02:00
Michael Görner
466bd79b73
Use MoveIt's codecov configuration ( #173 )
2020-06-11 10:43:01 +02:00